generated from canonical/template-operator
-
Notifications
You must be signed in to change notification settings - Fork 16
[DPE-7322] Support predefined roles #652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
350dc94
to
90bb3c8
Compare
2bb4cdc
to
ef8e039
Compare
d6ef3e2
to
0d020f4
Compare
e9ba0fb
to
8000b34
Compare
2c8e14b
to
bd05e71
Compare
taurus-forever
approved these changes
Aug 19, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done! Easy to read!
paulomach
approved these changes
Aug 29, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work. Tests are solid
bd05e71
to
77207f7
Compare
PR branch rebased from |
2a87e32
to
82844ed
Compare
82844ed
to
29e304e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the set of predefined roles proposed in this specification.
In addition to the predefined roles proposed to be on sync with PostgreSQL 16 operators, there is an additional one in order to solve a long time standing time debt:
mysqlrouter
. This predefined role is proposed in order to stop treating mysqlrouter as a magic word used to assignALL PRIVILEGES
to the created users whoseextra-user-roles
config argument contained such word. That exact name has been chosen to preserve backwards compatibility.Additional changes:
extra-user-roles
config argument._
) instead of mixing dashes and underscores.